Others have pretty much covered all the bases on your first question, so i'll skip that.
Any profession will work with any class, so ultimately it's just a matter of personal preference.
Originally Posted by Spiritman77
Weapon and armour professions are devalued from around lv60 onwards, by which point most people will be using bartered armour sets and legendary items, rather than crafting gear (Crafted weapons do remain viable for off-hand weapon however). So if you're looking to make loads of money, these probably aren't the options for you.
Similarly, cooking tends to involve a large amount of effort, but the value of the items isn't very much. Although everyone will use food. So again, It's not likely to make you much in the long run.
Jeweller works well, because jewellery remains desirable throughout the game. Yes, ultimately at level cap there will be options which may be "better" or "preferable" earned through bartering, loot, or other methods. But guild jewellery tends to be people's first stop for gearing out their character, and thus these items can be sold for decent values for relatively minimal effort. As a Tinker professional, you will also be able to collect your own ores via Prospecting. Which you can then use for your jewelery requirements, and sell any excess ores (Ores tend to sell at relatively high prices, particularly for lower tier ores).
Your main concern, if you want to be completely self-sufficient with crafting, would be to have all the crafting professions (and guild membership) covered by multiple characters.
[SIZE=3][b]Leader of [COLOR="#FFD700"]The Rangers of Eriador[/COLOR], Snowbourn[/b][/SIZE]
[color=#00BF00]Brya, Balthelion, Fyore, Iarngard, Madic, Eoradain, Trystana, Pendalas, Kharmul, Arkunir, Holibrand, Tifridh, Freawyn, Adlanniel, Tiraniel, Lilija, Theda[/color]
[URL="http://www.youtube.com/playlist?list=PL0szyANQhriMn42fCDdke1EMAOcdzmr9v"]Let's Play LOTRO (YouTube Series)[/URL] ~ [URL="https://www.lotro.com/forums/showthread.php?461498-The-Rangers-of-Eriador"]Kin Info/Recruitment[/URL]